Skip to content

[CIR][ThroughMLIR] Lower structs and GetMemberOp. #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CIR][ThroughMLIR] Lower structs and GetMemberOp. #1943

wants to merge 1 commit into from

Conversation

terapines-osc-cir
Copy link
Contributor

The PR1565 contains too many conflicts with the main branch.

Got it re-patched to the current main branch.

Structs are implemented as memref. It is not feasible to represent them as tuples,
for tuples can't be put in memref (i.e. pointers to structs would break if we did).

We use memref::ViewOp for this. Unlike PtrStrideOp, the reinterpret cast operation doesn't work here,
as the result type is potentially different from i8.

@bcardosolopes bcardosolopes mentioned this pull request Oct 10, 2025
Closed
bcardosolopes
bcardosolopes approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending minor nits

clang/lib/CIR/Dialect/IR/CIRTypes.cpp Outdated
assert(idx < getNumElements());
auto members = getMembers();

// unsigned offset = 0, recordSize = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all commented code snippets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all commented code snippets

Yes, they will be removed soon. I was trying to figure out why the test on windows-2022 failed, but i don't have a windows machine, so I changed some code and pushed it for testing.

@bcardosolopes
Copy link
Member

and also pending tests passing :)

@terapines-osc-cir
Copy link
Contributor Author

and also pending tests passing :)

Yes, I am working on them. (trying to get a local windows machine now)

@terapines-osc-cir
Copy link
Contributor Author

Hi, I got stuck on the failed CIR test (Clang CIR Tests/ Test clang-cir / Lit Tests (windows-2022)).

I don't have windows 2022 machine, so I tried to build the project on a Windows10 machine with MS toolchain (Visual Studio 17 2022) and run the test. I was hoping to reproduce the failure and do some debugging on that Window machine, but the test passed. Now I am trying to get a window-2022 machine but that will take some time.

Can someone give me some clues on this test failure?

@terapines-osc-cir
Copy link
Contributor Author

Hi, I got stuck on the failed CIR test (Clang CIR Tests/ Test clang-cir / Lit Tests (windows-2022)).

I don't have windows 2022 machine, so I tried to build the project on a Windows10 machine with MS toolchain (Visual Studio 17 2022) and run the test. I was hoping to reproduce the failure and do some debugging on that Window machine, but the test passed. Now I am trying to get a window-2022 machine but that will take some time.

Can someone give me some clues on this test failure?

I build the project on Windows Server 2022 Standard Evaluation 21H2, OS build 20348.587, it passed, too. (Visual Studio Community 2022 17.14.16)

I can not reproduce this test failure yet. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

@andykaylor andykaylor Awaiting requested review from andykaylor andykaylor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terapines-osc-cir @bcardosolopes